Chromium Code Reviews
Help | Chromium Project | Sign in
(198)

Issue 5183007: Polish the Enumerate Modules implementation a bit.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by Finnur (OOO - vacation)
Modified:
4 years, 1 month ago
Reviewers:
huanr
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Polish the Enumerate Modules implementation a bit. 1) De-dup the registered DLLs since a lot of the same DLLs will be registered multiple times, ie. mswsock.dll 2) Every module loaded from a %temp% dir should be viewed as suspicious. 3) Add some histogram counters (xml changes coming in a followup CL). BUG=http://crbug.com/51105 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66880

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -5 lines) Patch
M chrome/browser/enumerate_modules_model_win.h View 3 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/enumerate_modules_model_win.cc View 11 chunks +72 lines, -4 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
Finnur (OOO - vacation)
4 years, 8 months ago (2010-11-19 19:21:34 UTC) #1
huanr
4 years, 8 months ago (2010-11-19 19:45:47 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5