App-list history cleanup.

App-list history cleanup.

This CL centralizes the dependency to content, so that other files
can run independently.

BUG=380875
R=xiyuan@chromium.org
TEST=build

Committed: https://crrev.com/d2b0dfede32daea43a59c5251c4cce0d03789302
Cr-Commit-Position: refs/heads/master@{#293065}

[xiyuan, 2014-08-29 22:14:37]

lgtm

https://codereview.chromium.org/518293002/diff/20001/chrome/browser/ui/app_li...
File chrome/browser/ui/app_list/search/history_data_store.cc (right):

https://codereview.chromium.org/518293002/diff/20001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/search/history_data_store.cc:131:
data_store_->Flush(on_flushed);
|on_flushed| should be called in an "else" like in Load() below.

https://codereview.chromium.org/518293002/diff/20001/chrome/browser/ui/app_li...
File chrome/browser/ui/app_list/search/history_data_store.h (right):

https://codereview.chromium.org/518293002/diff/20001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/search/history_data_store.h:74:
scoped_ptr<base::DictionaryValue> cached_dict_;
nit: Comment that |cached_dict_| and |data_store_| are mutually exclusive. Only
one of them would be used.

[Jun Mukai, 2014-09-02 22:11:57]

https://codereview.chromium.org/518293002/diff/20001/chrome/browser/ui/app_li...
File chrome/browser/ui/app_list/search/history_data_store.cc (right):

https://codereview.chromium.org/518293002/diff/20001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/search/history_data_store.cc:131:
data_store_->Flush(on_flushed);
On 2014/08/29 22:14:37, xiyuan wrote:
> |on_flushed| should be called in an "else" like in Load() below.

Done.

https://codereview.chromium.org/518293002/diff/20001/chrome/browser/ui/app_li...
File chrome/browser/ui/app_list/search/history_data_store.h (right):

https://codereview.chromium.org/518293002/diff/20001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/search/history_data_store.h:74:
scoped_ptr<base::DictionaryValue> cached_dict_;
On 2014/08/29 22:14:37, xiyuan wrote:
> nit: Comment that |cached_dict_| and |data_store_| are mutually exclusive.
Only
> one of them would be used.

Done.

[Jun Mukai, 2014-09-02 22:12:00]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-09-02 22:13:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/518293002/40001

[commit-bot: I haz the power, 2014-09-02 22:31:56]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/49240)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/54567)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-09-02 22:36:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-02 22:36:51]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/49253)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/54579)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[Jun Mukai, 2014-09-02 23:25:39]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-09-02 23:29:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/518293002/60001

[Jun Mukai, 2014-09-03 01:18:03]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-09-03 01:19:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/518293002/80001

[commit-bot: I haz the power, 2014-09-03 02:32:03]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-09-03 02:46:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-03 02:46:57]

Try jobs failed on following builders:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Jun Mukai, 2014-09-03 03:35:18]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-09-03 03:35:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/518293002/80001

[commit-bot: I haz the power, 2014-09-03 04:41:04]

Committed patchset #5 (id:80001) as 7e715d6490b2f25c787a9cef3c9174d05fd61cd3

[commit-bot: I haz the power, 2014-09-10 03:23:22]

Patchset 5 (id:??) landed as
https://crrev.com/d2b0dfede32daea43a59c5251c4cce0d03789302
Cr-Commit-Position: refs/heads/master@{#293065}