Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 518213003: Rename ScaledImageCache.cpp to SkResourceCacheTest.cpp (Closed)

Created:
6 years, 3 months ago by Rémi Piotaix
Modified:
6 years, 3 months ago
Reviewers:
reed, tfarina, Justin Novosad
CC:
reviews_skia.org, mtklein
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Rename ScaledImageCache.cpp to SkResourceCacheTest.cpp BUG=skia: Committed: https://skia.googlesource.com/skia/+/aca21d6d2f9984da8f941b76f4ee11772d0e48ec

Patch Set 1 #

Patch Set 2 : Rebase master #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -74 lines) Patch
M gyp/tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
D tests/ScaledImageCache.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
A + tests/SkResourceCacheTest.cpp View 0 chunks +-1 lines, --1 lines 2 comments Download

Messages

Total messages: 10 (4 generated)
Rémi Piotaix
PTAL
6 years, 3 months ago (2014-08-29 20:29:34 UTC) #2
Justin Novosad
lgtm
6 years, 3 months ago (2014-09-02 18:37:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/piotaixr@chromium.org/518213003/20001
6 years, 3 months ago (2014-09-02 18:43:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as aca21d6d2f9984da8f941b76f4ee11772d0e48ec
6 years, 3 months ago (2014-09-02 18:51:03 UTC) #7
tfarina
lgtm (we may have a trend to 'fix' this one day, i.e., SkFoo -> tests/SkFooTest.cpp). ...
6 years, 3 months ago (2014-09-03 17:06:42 UTC) #9
Rémi Piotaix
6 years, 3 months ago (2014-09-03 17:26:18 UTC) #10
Message was sent while issue was closed. 
https://codereview.chromium.org/518213003/diff/20001/tests/SkResourceCacheTes...
File tests/SkResourceCacheTest.cpp (right):

https://codereview.chromium.org/518213003/diff/20001/tests/SkResourceCacheTes...
tests/SkResourceCacheTest.cpp:2: * Copyright 2014 Google Inc.
On 2014/09/03 17:06:42, tfarina wrote:
> tests/ResourceCacheTest.cpp
> 
> As Mike likes to remind me :)

ResourceCacheTest.cpp already exists but it is for GrResourceCache :D

Powered by Google App Engine
This is Rietveld 408576698