Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: content/renderer/render_widget.cc

Issue 518123002: Always guard against IME events for all KeyPress. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: don't block events for <tab> Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 7ac5c8ef79820d2ccc1c6fac2e714f376f89e6b6..d9f620d58fb047e9637e434430a094712f9791ba 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -934,7 +934,7 @@ void RenderWidget::OnHandleInputEvent(const blink::WebInputEvent* input_event,
base::AutoReset<WebInputEvent::Type> handling_event_type_resetter(
&handling_event_type_, input_event->type);
#if defined(OS_ANDROID)
- // On Android, when the delete key or forward delete key is pressed using IME,
+ // On Android, when a key is pressed or sent from the Keyboard using IME,
// |AdapterInputConnection| generates input key events to make sure all JS
// listeners that monitor KeyUp and KeyDown events receive the proper key
// code. Since this input key event comes from IME, we need to set the
@@ -944,10 +944,9 @@ void RenderWidget::OnHandleInputEvent(const blink::WebInputEvent* input_event,
if (WebInputEvent::isKeyboardEventType(input_event->type)) {
const WebKeyboardEvent& key_event =
*static_cast<const WebKeyboardEvent*>(input_event);
- if (key_event.nativeKeyCode == AKEYCODE_FORWARD_DEL ||
- key_event.nativeKeyCode == AKEYCODE_DEL) {
+ // Some keys are special and it's essential that no events get blocked.
+ if (key_event.nativeKeyCode != AKEYCODE_TAB)
ime_event_guard_maybe.reset(new ImeEventGuard(this));
- }
}
#endif
« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698