Issue 518083: Make sure that pointer to the ExtensionsService is valid in the extensions infobars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 518083: Make sure that pointer to the ExtensionsService is valid in the extensions infobars. (Closed)

Created:
10 years, 11 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman, Erik does not do reviews, Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Make sure that pointer to the ExtensionsService is valid in the extensions infobars. TEST=none BUG=29106

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -3 lines)			Patch
M	chrome/browser/extensions/crashed_extension_infobar.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/crashed_extension_infobar.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_disabled_infobar_delegate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Paweł Hajdan Jr.

Aaron: if you prefer, I can extend the ExtensionsService to have destruction observers or things ...

10 years, 11 months ago (2010-01-08 15:13:27 UTC) #1

Aaron Boodman

Can you explain what you think is happening and why this fixes it? It seems ...

10 years, 11 months ago (2010-01-11 16:55:37 UTC) #2

Paweł Hajdan Jr.

+erikkay for possibly more ideas So, I suspect that the pointer to ExtensionsService becomes invalid, ...

10 years, 11 months ago (2010-01-11 18:39:53 UTC) #3

Paweł Hajdan Jr.

10 years, 11 months ago (2010-01-11 20:43:00 UTC) #4

After looking at the crash stack traces analysis done by Aaron this patch
doesn't look like the best approach. I'll close it.