Settings to control Add Person and Browse as Guest.

chrome/browser/browser_process_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_process_impl.h"
 
 #include <algorithm>
 #include <map>
 #include <vector>
 
@@ skipping 765 matching lines @@
   registry->RegisterBooleanPref(prefs::kDefaultBrowserSettingEnabled,
                                 false);
   // This policy needs to be defined before the net subsystem is initialized,
   // so we do it here.
   registry->RegisterIntegerPref(prefs::kMaxConnectionsPerProxy,
                                 net::kDefaultMaxSocketsPerProxyServer);
 
   registry->RegisterBooleanPref(prefs::kAllowCrossOriginAuthPrompt, false);
 
   registry->RegisterBooleanPref(prefs::kBrowserGuestModeEnabled, true);
+  registry->RegisterBooleanPref(prefs::kBrowserAddPersonEnabled, true);

[sky, 2014/09/02 18:19:12]

Seems a bit arbitrary that the pref is registered here and not in a location
closer to where this is used. Is there a better place for the registration to
live?

[Mike Lerman, 2014/09/04 14:37:08]

I can put it in c/b/ui/browser_ui_prefs. There doesn't seem to be anything
closer to the settings page. (Done in this patch)

There could be a case for c/b/profiles/profile_state.cc, although these really
are UI and Settings related Prefs, moreso than profiles.

Otherwise I can create a new RegistryPrefs method within c/b/ui/webui/options,
likely within OptionsUI. I'll defer to you as to when it's warranted to split
off a new home for registering prefs.

[Evan Stade, 2014/09/04 18:10:13]

I think you should put them here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/pro...

[Mike Lerman, 2014/09/04 20:58:50]

Chatted with noms - she agreed.

 
 #if defined(OS_CHROMEOS) || defined(OS_ANDROID) || defined(OS_IOS)
   registry->RegisterBooleanPref(prefs::kEulaAccepted, false);
 #endif  // defined(OS_CHROMEOS) || defined(OS_ANDROID) || defined(OS_IOS)
 #if defined(OS_WIN)
   if (base::win::GetVersion() >= base::win::VERSION_WIN7) {
     registry->RegisterStringPref(prefs::kRelaunchMode,
                                  upgrade_util::kRelaunchModeDefault);
   }
 #endif
@@ skipping 421 matching lines @@
 }
 
 void BrowserProcessImpl::OnAutoupdateTimer() {
   if (CanAutorestartForUpdate()) {
     DLOG(WARNING) << "Detected update.  Restarting browser.";
     RestartBackgroundInstance();
   }
 }
 
 #endif  // (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS)