Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 51803002: [Telemetry] Fix page sets with both file:// and http:// URLs on Android. (Closed)

Created:
7 years, 1 month ago by tonyg
Modified:
7 years, 1 month ago
Reviewers:
dtu, ernstm
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Fix page sets with both file:// and http:// URLs on Android. When we start the browser, it is configured to always use WPR (this makes http work). When we go to hit the file:// URL, we need to hit the other web server instead of WPR, but we can't reconfigure Chrome without restarting. So, WPR has logic to forward any 127.0.0.1 requests on to another server to allow the local HTTP server to get the requests. The problem was that we were explicitly requesting localhost instead of 127.0.0.1 which fooled WPR. BUG=311582 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/core/backends/adb_commands.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
tonyg
7 years, 1 month ago (2013-10-30 00:19:49 UTC) #1
dtu
lgtm This is goofy. Will we also have problems with WPR archives recorded using a ...
7 years, 1 month ago (2013-10-30 00:52:46 UTC) #2
ernstm
LGTM
7 years, 1 month ago (2013-10-30 00:57:33 UTC) #3
tonyg
> This is goofy. I agree. It kind of smells. I'll try to think of ...
7 years, 1 month ago (2013-10-30 01:41:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/51803002/1
7 years, 1 month ago (2013-10-30 02:06:11 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-10-30 03:06:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/51803002/1
7 years, 1 month ago (2013-10-30 04:53:11 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=94945
7 years, 1 month ago (2013-10-30 13:50:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/51803002/1
7 years, 1 month ago (2013-10-30 13:54:54 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 17:05:01 UTC) #10
Message was sent while issue was closed.
Change committed as 231858

Powered by Google App Engine
This is Rietveld 408576698