Issue 518028: views/gtk: Add missing keyboard accelerators to Search Engines dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 518028: views/gtk: Add missing keyboard accelerators to Search Engines dialog. (Closed)

Created:
10 years, 11 months ago by tfarina (gmail-do not use)

Modified:
9 years, 7 months ago

Reviewers:
Finnur, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

views/gtk: Add missing keyboard accelerators to Search Engines dialog. BUG=16380 TEST=manual Patch from Thiago Farina <thiago.farina@gmail.com>;. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35499

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -7 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/keyword_editor_view.cc	View	2 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/views/keyword_editor_view.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

tfarina (gmail-do not use)

Hi Evan, could you review this to me?

10 years, 11 months ago (2009-12-31 17:01:09 UTC) #1

tfarina (gmail-do not use)

On 2009/12/31 19:29:53, Evan Martin wrote: > Does this look ok on Mac? Without a ...

10 years, 11 months ago (2009-12-31 21:03:15 UTC) #3

tfarina (gmail-do not use)

On 2009/12/31 21:03:15, tfarina wrote: > On 2009/12/31 19:29:53, Evan Martin wrote: > > Does ...

10 years, 11 months ago (2010-01-03 14:45:01 UTC) #4

LGTM, sending to trybots