Issue 518023002: Move base library definitions from v8.gyp to base.gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 518023002: Move base library definitions from v8.gyp to base.gyp. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer

Modified:
6 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev, jochen (gone - plz use gerrit), tfarina

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Move base library definitions from v8.gyp to base.gyp. Less confusion is best confusion. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23518

Patch Set 1 #

Total comments: 2

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+253 lines, -253 lines)			Patch
M	build/all.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/base/base.gyp	View	1 chunk	+250 lines, -1 line	2 comments	Download
M	tools/gyp/v8.gyp	View	2 chunks	+2 lines, -251 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM, but this makes my https://codereview.chromium.org/521593002/ unhappy. Oh well... :-/

6 years, 3 months ago (2014-08-29 11:17:26 UTC) #2

Benedikt Meurer

Committed patchset #1 manually as 23518 (presubmit successful).

6 years, 3 months ago (2014-08-29 11:18:59 UTC) #3

tfarina

6 years, 3 months ago (2014-08-29 15:09:38 UTC) #4

Message was sent while issue was closed.

When you reland, could you consider the comment in base.gyp:68?

Thanks for moving this target out of v8.gyp.

https://codereview.chromium.org/518023002/diff/1/src/base/base.gyp
File src/base/base.gyp (right):

https://codereview.chromium.org/518023002/diff/1/src/base/base.gyp#newcode17
src/base/base.gyp:17: 'include_dirs+': [
include_dirs+? I don't recall seem this on Chromium.

https://codereview.chromium.org/518023002/diff/1/src/base/base.gyp#newcode68
src/base/base.gyp:68: 'link_settings': {
I think you should keep indenting two spaces here as well (not four).

Expand Messages | Collapse Messages