Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 517993002: Refactoring InterfaceDescriptors away from code-stubs.h (Closed)

Created:
6 years, 3 months ago by mvstanton
Modified:
6 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Refactoring InterfaceDescriptors away from code-stubs.h Clean up and create seperation between the concept of a call descriptor and a code stub interface descriptor. The former is just concerned with how to call, but the latter has many extra hints related to code generation and deoptimization for the implementation of a particular code stub. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23515

Patch Set 1 #

Patch Set 2 : Ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+667 lines, -516 lines) Patch
M BUILD.gn View 1 5 chunks +8 lines, -0 lines 0 comments Download
M src/arm/code-stubs-arm.h View 1 1 chunk +0 lines, -14 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 chunks +0 lines, -88 lines 0 comments Download
A src/arm/interface-descriptors-arm.h View 1 1 chunk +26 lines, -0 lines 0 comments Download
A src/arm/interface-descriptors-arm.cc View 1 1 chunk +108 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.h View 1 1 chunk +0 lines, -14 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 chunks +0 lines, -88 lines 0 comments Download
A src/arm64/interface-descriptors-arm64.h View 1 1 chunk +26 lines, -0 lines 0 comments Download
A src/arm64/interface-descriptors-arm64.cc View 1 1 chunk +108 lines, -0 lines 0 comments Download
M src/code-stubs.h View 4 chunks +1 line, -95 lines 0 comments Download
M src/code-stubs.cc View 3 chunks +0 lines, -46 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +0 lines, -77 lines 0 comments Download
A src/ia32/interface-descriptors-ia32.cc View 1 chunk +97 lines, -0 lines 0 comments Download
A src/interface-descriptors.h View 1 1 chunk +126 lines, -0 lines 0 comments Download
A src/interface-descriptors.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -10 lines 0 comments Download
M src/isolate.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 chunks +0 lines, -77 lines 0 comments Download
A src/x64/interface-descriptors-x64.cc View 1 1 chunk +97 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 5 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mvstanton
mvstanton@chromium.org changed reviewers: + yangguo@chromium.org
6 years, 3 months ago (2014-08-29 09:46:37 UTC) #1
mvstanton
Hi Yang, This begins the process we discussed, please have a look, thx! --Michael
6 years, 3 months ago (2014-08-29 09:46:37 UTC) #2
mvstanton
Added ports, which meant a new header file on arm and arm64. --Michael
6 years, 3 months ago (2014-08-29 10:27:30 UTC) #3
Yang
On 2014/08/29 10:27:30, mvstanton wrote: > Added ports, which meant a new header file on ...
6 years, 3 months ago (2014-08-29 10:39:18 UTC) #4
mvstanton
6 years, 3 months ago (2014-08-29 10:40:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 23515 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698