Issue 517963002: Video Player: Fix the condition of 'ended' property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 517963002: Video Player: Fix the condition of 'ended' property (Closed)

Created:
6 years, 3 months ago by yoshiki

Modified:
6 years, 3 months ago

Reviewers:
fukino

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Video Player: Fix the condition of 'ended' property Once the user tries starting the video, the video should not be 'ended'. BUG=none TEST=none Committed: https://crrev.com/ced81ce9afdd0d087a3d2e072889d18c302ce729 Cr-Commit-Position: refs/heads/master@{#292617}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	ui/file_manager/video_player/js/cast/cast_video_element.js	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

yoshiki

yoshiki@chromium.org changed reviewers: + fukino@chromium.org

6 years, 3 months ago (2014-08-29 11:31:39 UTC) #1

fukino

On 2014/08/29 11:32:33, yoshiki wrote: > @fukiuno-san, PTAL. Thanks. lgtm!

6 years, 3 months ago (2014-08-29 12:15:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/517963002/1

6 years, 3 months ago (2014-08-29 12:20:50 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 1f65cb44832948e89935beb7a79c106ad773ee85

6 years, 3 months ago (2014-08-29 13:19:46 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:08:04 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ced81ce9afdd0d087a3d2e072889d18c302ce729
Cr-Commit-Position: refs/heads/master@{#292617}

Expand Messages | Collapse Messages