Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2048)

Unified Diff: chrome/browser/process_singleton.h

Issue 517933002: Speed up and re-enable ProcessSingletonPosixTest tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lower test timeout a little more Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/process_singleton_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/process_singleton.h
diff --git a/chrome/browser/process_singleton.h b/chrome/browser/process_singleton.h
index 300c3a12b7a6a44f51b8501612006c2e5891118d..08dd70e5a600a4ad759ed2c8ffdeb2d8d0ec1166 100644
--- a/chrome/browser/process_singleton.h
+++ b/chrome/browser/process_singleton.h
@@ -105,21 +105,19 @@ class ProcessSingleton : public base::NonThreadSafe {
// this timeout to be short.
NotifyResult NotifyOtherProcessWithTimeout(
const base::CommandLine& command_line,
- int timeout_seconds,
+ int retry_attempts,
+ const base::TimeDelta& timeout_interval,
Nico 2014/09/08 19:04:18 nit: i'd just call this timeout I think, the type
mattm 2014/09/09 00:06:14 Done.
bool kill_unresponsive);
NotifyResult NotifyOtherProcessWithTimeoutOrCreate(
const base::CommandLine& command_line,
- int timeout_seconds);
+ int retry_attempts,
+ const base::TimeDelta& timeout_interval);
void OverrideCurrentPidForTesting(base::ProcessId pid);
void OverrideKillCallbackForTesting(
const base::Callback<void(int)>& callback);
#endif
private:
- // Timeout for the current browser process to respond. 20 seconds should be
- // enough.
- static const int kTimeoutInSeconds = 20;
-
NotificationCallback notification_callback_; // Handler for notifications.
#if defined(OS_WIN)
« no previous file with comments | « no previous file | chrome/browser/process_singleton_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698