Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 517933002: Speed up and re-enable ProcessSingletonPosixTest tests. (Closed)

Created:
6 years, 3 months ago by mattm
Modified:
6 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Speed up and re-enable ProcessSingletonPosixTest tests. Clean up time handling in process_singleton_posix.cc so that it is usable with sub-second timeouts. BUG=407065 Committed: https://crrev.com/a92250eb824c4f23ca2dab70d3029a52650591c1 Cr-Commit-Position: refs/heads/master@{#293886}

Patch Set 1 #

Patch Set 2 : lower test timeout a little more #

Total comments: 2

Patch Set 3 : rename timeout_interval to timeout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -63 lines) Patch
M chrome/browser/process_singleton.h View 1 2 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/process_singleton_posix.cc View 1 2 8 chunks +52 lines, -28 lines 0 comments Download
M chrome/browser/process_singleton_posix_unittest.cc View 1 2 10 chunks +20 lines, -29 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mattm
6 years, 3 months ago (2014-08-29 19:22:56 UTC) #2
mattm
On 2014/08/29 19:22:56, mattm wrote: ping
6 years, 3 months ago (2014-09-04 18:10:30 UTC) #3
Nico
lgtm https://codereview.chromium.org/517933002/diff/20001/chrome/browser/process_singleton.h File chrome/browser/process_singleton.h (right): https://codereview.chromium.org/517933002/diff/20001/chrome/browser/process_singleton.h#newcode109 chrome/browser/process_singleton.h:109: const base::TimeDelta& timeout_interval, nit: i'd just call this ...
6 years, 3 months ago (2014-09-08 19:04:18 UTC) #4
mattm
https://codereview.chromium.org/517933002/diff/20001/chrome/browser/process_singleton.h File chrome/browser/process_singleton.h (right): https://codereview.chromium.org/517933002/diff/20001/chrome/browser/process_singleton.h#newcode109 chrome/browser/process_singleton.h:109: const base::TimeDelta& timeout_interval, On 2014/09/08 19:04:18, Nico (hiding) wrote: ...
6 years, 3 months ago (2014-09-09 00:06:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/517933002/40001
6 years, 3 months ago (2014-09-09 00:28:52 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as cd0c30c61975be00d2d230c32b886185728e348b
6 years, 3 months ago (2014-09-09 07:32:41 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:51:41 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/a92250eb824c4f23ca2dab70d3029a52650591c1
Cr-Commit-Position: refs/heads/master@{#293886}

Powered by Google App Engine
This is Rietveld 408576698