Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: runtime/include/dart_debugger_api.h

Issue 51793002: Add an API function to get a debugger stack trace from an error handle. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/dart_api_impl.cc » ('j') | runtime/vm/dart_api_impl_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/include/dart_debugger_api.h
diff --git a/runtime/include/dart_debugger_api.h b/runtime/include/dart_debugger_api.h
index 0c9c4049a0efc32a8eff92f24cd8cf88ca3ef69a..b02ca893d31174c5e0164a7450f1ac07c5d422bd 100755
--- a/runtime/include/dart_debugger_api.h
+++ b/runtime/include/dart_debugger_api.h
@@ -352,7 +352,7 @@ DART_EXPORT Dart_Handle Dart_SetExceptionPauseInfo(
DART_EXPORT Dart_ExceptionPauseInfo Dart_GetExceptionPauseInfo();
/**
- * Returns in \trace the the current stack trace, or NULL if the
+ * Returns in \trace the current stack trace, or NULL if the
* VM is not paused.
*
* Requires there to be a current isolate.
@@ -363,6 +363,17 @@ DART_EXPORT Dart_Handle Dart_GetStackTrace(Dart_StackTrace* trace);
/**
+ * Returns in \trace the stack trace associated with the error given in \handle.
+ *
+ * Requires there to be a current isolate.
+ *
+ * \return A handle to the True object if no error occurs.
siva 2013/11/12 16:00:43 why a handle to the True object and not Success li
rmacnak 2013/11/12 22:32:40 It does return Success. Copied from doc for Dart_G
+ */
+DART_EXPORT Dart_Handle Dart_GetStackTraceFromError(Dart_Handle handle,
+ Dart_StackTrace* trace);
+
+
+/**
* Returns in \length the number of activation frames in the given
* stack trace.
*
@@ -416,6 +427,30 @@ DART_EXPORT Dart_Handle Dart_ActivationFrameInfo(
/**
+ * Returns information about the given activation frame.
+ * \function_name receives a string handle with the qualified
+ * function name.
+ * \script_url receives a string handle with the url of the
+ * source script that contains the frame's function.
+ * \line_number receives the line number in the script.
+ * \col_number receives the line number in the script, or -1 if column
+ * information is not available
+ *
+ * Any or all of the out parameters above may be NULL.
+ *
+ * Requires there to be a current isolate.
+ *
+ * \return A handle to the True object if no error occurs.
siva 2013/11/12 16:00:43 Ditto comment regarding returning Success.
+ */
+DART_EXPORT Dart_Handle Dart_ActivationFrameInfoWithColumn(
+ Dart_ActivationFrame activation_frame,
+ Dart_Handle* function_name,
+ Dart_Handle* script_url,
+ intptr_t* line_number,
+ intptr_t* column_number);
siva 2013/11/12 16:00:43 If we decide to get rid of the other version of Ac
rmacnak 2013/11/12 22:32:40 Done.
+
+
+/**
* Returns code location of the given activation frame.
*
* \function_name receives a string handle with the qualified
« no previous file with comments | « no previous file | runtime/vm/dart_api_impl.cc » ('j') | runtime/vm/dart_api_impl_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698