Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: extensions/common/api/usb_private.idl

Issue 517923002: Add more generic filters to the chrome.usb.getDevices API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Function comments are descriptive. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/api/usb.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/api/usb_private.idl
diff --git a/extensions/common/api/usb_private.idl b/extensions/common/api/usb_private.idl
index 457da232416c8b247b4229fa90bcde8f65f53ac8..71a4ff2d4e797fe64d6aead5cb59e3f64751b820 100644
--- a/extensions/common/api/usb_private.idl
+++ b/extensions/common/api/usb_private.idl
@@ -7,22 +7,6 @@
// API which should only be available to trusted pages.
namespace usbPrivate {
- // Properties for matching devices. A device matches of any of its interfaces
- // match the given properties. An empty dictionary matches any device.
- dictionary DeviceFilter {
- // Device-level matching criteria:
- long? vendorId;
- // Checked only if the vendorId matches.
- long? productId;
-
- // Per-interface matching criteria:
- long? interfaceClass;
- // Checked only if the interfaceClass matches.
- long? interfaceSubclass;
- // Checked only if the interfaceSubclass matches.
- long? interfaceProtocol;
- };
-
dictionary DeviceInfo {
long vendorId; // idVendor from the device
long productId; // idProduct from the device
@@ -44,7 +28,7 @@ namespace usbPrivate {
// Lists USB devices matching any of the given filters.
// |filters|: The properties to search for on target devices.
// |callback|: Invoked with a list of device IDs on complete.
- static void getDevices(DeviceFilter[] filters,
+ static void getDevices(usb.DeviceFilter[] filters,
GetDevicesCallback callback);
// Gets basic display information about a device.
« no previous file with comments | « extensions/common/api/usb.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698