Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 517923002: Add more generic filters to the chrome.usb.getDevices API. (Closed)

Created:
6 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add more generic filters to the chrome.usb.getDevices API. Instead of specifying each of the USB vendor and product ID pairs an app has permission to open this API extension allows filtering of devices by vendor and product IDs as well as USB interface classes, sub- classes and protocols. The 'vendorId' and 'productId' properties of EnumerateDevicesOptions are still supported for backwards compatibility. BUG= Committed: https://crrev.com/7c403e06d1b61459b19434df22ca538216a4ba93 Cr-Commit-Position: refs/heads/master@{#293032}

Patch Set 1 #

Patch Set 2 : Clean up the USB API documentation. #

Total comments: 2

Patch Set 3 : Function comments are descriptive. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -221 lines) Patch
M components/usb_service/usb_device_filter.h View 2 chunks +6 lines, -1 line 0 comments Download
M components/usb_service/usb_device_filter.cc View 3 chunks +14 lines, -2 lines 0 comments Download
M components/usb_service/usb_device_filter_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M extensions/browser/api/usb/usb_api.h View 2 chunks +8 lines, -1 line 0 comments Download
M extensions/browser/api/usb/usb_api.cc View 1 2 6 chunks +55 lines, -38 lines 0 comments Download
M extensions/browser/api/usb_private/usb_private_api.cc View 1 2 3 chunks +8 lines, -35 lines 0 comments Download
M extensions/common/api/usb.idl View 1 2 3 chunks +131 lines, -127 lines 0 comments Download
M extensions/common/api/usb_private.idl View 2 chunks +1 line, -17 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Reilly Grant (use Gerrit)
reillyg@chromium.org changed reviewers: + kalman@chromium.org, rockot@chromium.org, rpaquay@chromium.org
6 years, 3 months ago (2014-08-29 02:22:29 UTC) #1
Reilly Grant (use Gerrit)
6 years, 3 months ago (2014-08-29 02:22:35 UTC) #2
Reilly Grant (use Gerrit)
I've cleaned up the USB API documentation.
6 years, 3 months ago (2014-08-29 22:56:05 UTC) #3
Ken Rockot(use gerrit already)
lgtm with doc nit https://codereview.chromium.org/517923002/diff/20001/extensions/common/api/usb.idl File extensions/common/api/usb.idl (right): https://codereview.chromium.org/517923002/diff/20001/extensions/common/api/usb.idl#newcode300 extensions/common/api/usb.idl:300: // Try to reset the ...
6 years, 3 months ago (2014-09-02 21:25:38 UTC) #4
Reilly Grant (use Gerrit)
https://codereview.chromium.org/517923002/diff/20001/extensions/common/api/usb.idl File extensions/common/api/usb.idl (right): https://codereview.chromium.org/517923002/diff/20001/extensions/common/api/usb.idl#newcode300 extensions/common/api/usb.idl:300: // Try to reset the USB device. On 2014/09/02 ...
6 years, 3 months ago (2014-09-02 22:03:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/517923002/40001
6 years, 3 months ago (2014-09-02 22:07:46 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 227ba73ed5392fe061411d5db103b32183e5d9de
6 years, 3 months ago (2014-09-03 00:53:22 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:22:17 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7c403e06d1b61459b19434df22ca538216a4ba93
Cr-Commit-Position: refs/heads/master@{#293032}

Powered by Google App Engine
This is Rietveld 408576698