Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1599)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 517873003: Revert of Net-related fixups for scoped_refptr conversion operator cleanup. (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 3 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, gavinp+disk_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Net-related fixups for scoped_refptr conversion operator cleanup. (patchset #2 of https://codereview.chromium.org/511163002/) Reason for revert: It seems to be breaking GPU Mac Builder (Blink): http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder/builds/19306/steps/compile/logs/stdio Original issue's description: > Net-related fixups for scoped_refptr conversion operator cleanup. > > BUG=110610 > TBR=pkasting@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/aa3dd9e5a2d3215f9c756ddcbb11268569cbe473 TBR=mmenke@chromium.org,rsleevi@chromium.org,pkasting@chromium.org,dcheng@chromium.org NOTREECHECKS=true NOTRY=true BUG=110610 Committed: https://crrev.com/4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd Cr-Commit-Position: refs/heads/master@{#292606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -47 lines) Patch
M chrome/browser/ssl/ssl_client_auth_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_client_auth_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_client_auth_requestor_mock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_client_auth_requestor_mock.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/disk_cache/simple/simple_index.h View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_index.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M net/http/transport_security_persister.h View 2 chunks +6 lines, -7 lines 0 comments Download
M net/http/transport_security_persister.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M net/websockets/websocket_inflater_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mlamouri (slow - plz ping)
Created Revert of Net-related fixups for scoped_refptr conversion operator cleanup.
6 years, 3 months ago (2014-08-29 11:20:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/517873003/1
6 years, 3 months ago (2014-08-29 11:21:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as a8efd6a9e4729a987ab27d9257a1384e807b6564
6 years, 3 months ago (2014-08-29 11:22:38 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:07:41 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd
Cr-Commit-Position: refs/heads/master@{#292606}

Powered by Google App Engine
This is Rietveld 408576698