Move ResourceResponseHead::error_code to SyncLoadResult.

Move ResourceResponseHead::error_code to SyncLoadResult.

Apart from the places which expect a SyncLoadResult, it's only read in
RedirectToFileResourceHandler. In that case, it's always net::OK;
ResourceLoader checks request_->status().is_success() first in
OnResponseStarted before calling CompleteResponseStarted().

BUG=none

Committed: https://crrev.com/015fd3277d904d8941d29c1dc77d91bdf2cbfa4a
Cr-Commit-Position: refs/heads/master@{#293216}

[davidben, 2014-08-29 18:54:07]

davidben@chromium.org changed reviewers:
+ mmenke@chromium.org

[davidben, 2014-08-29 18:54:08]

Minor simplification I came across.

(Looking at the Mojo URLLoader interface, an alternative interface would be that
you always get OnResponseStarted and that contains the error if it fails before
then, but that's not what ResourceLoader's interface looks like right now, so
probably should make it consistent at least.)

[mmenke, 2014-09-02 15:25:49]

LGTM

[davidben, 2014-09-02 16:20:10]

davidben@chromium.org changed reviewers:
+ jam@chromium.org

[davidben, 2014-09-02 16:20:10]

+jam for content/ OWNERS

[jam, 2014-09-03 17:33:16]

lgtm

[davidben, 2014-09-03 17:38:17]

davidben@chromium.org changed reviewers:
+ nasko@chromium.org

[davidben, 2014-09-03 17:38:18]

Oops, still need one more OWNER. +nasko for IPC.

[nasko, 2014-09-03 17:46:25]

IPC LGTM

[davidben, 2014-09-03 17:58:48]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-09-03 17:59:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davidben@chromium.org/517853004/1

[commit-bot: I haz the power, 2014-09-03 18:49:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-09-03 19:24:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-03 19:24:54]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[davidben, 2014-09-03 21:18:16]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-09-03 21:21:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davidben@chromium.org/517853004/1

[commit-bot: I haz the power, 2014-09-03 23:32:47]

Committed patchset #1 (id:1) as 694a12d89f76a34aacd2deba2b53e4ad8d073cd3

[commit-bot: I haz the power, 2014-09-10 03:28:23]

Patchset 1 (id:??) landed as
https://crrev.com/015fd3277d904d8941d29c1dc77d91bdf2cbfa4a
Cr-Commit-Position: refs/heads/master@{#293216}