Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 517853002: ChromeVox should not speak live regions that aren't in the document. (Closed)

Created:
6 years, 3 months ago by dmazzoni
Modified:
6 years, 3 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

ChromeVox should not speak live regions that aren't in the document. The underlying issue is that by the time we get around to processing a live region node from a mutation observer, the node may no longer be part of the DOM, in which case we should treat it as invisible. To fix it, fix cvox.DomUtil.hasInvisibleAncestor_ so that it returns true (invisible) if passed an element that's not actually part of the document. BUG=408821 Committed: https://crrev.com/6626c4c105693e908f133c29475666f42f6f42ca Cr-Commit-Position: refs/heads/master@{#292847}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/common/dom_util.js View 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/dom_util_test.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
dmazzoni
dmazzoni@chromium.org changed reviewers: + dtseng@chromium.org
6 years, 3 months ago (2014-08-28 23:00:13 UTC) #1
dmazzoni
6 years, 3 months ago (2014-08-28 23:00:13 UTC) #2
David Tseng
lgtm
6 years, 3 months ago (2014-08-29 16:52:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/517853002/1
6 years, 3 months ago (2014-09-01 06:43:39 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-09-01 07:38:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 39eaeb6498388cbdb73f4423dea316dec09ae0dd
6 years, 3 months ago (2014-09-01 08:18:14 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:16:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6626c4c105693e908f133c29475666f42f6f42ca
Cr-Commit-Position: refs/heads/master@{#292847}

Powered by Google App Engine
This is Rietveld 408576698