Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 517843005: Remove PrerenderCondition*. (Closed)

Created:
6 years, 3 months ago by Bence
Modified:
6 years, 3 months ago
CC:
chromium-reviews, davidben+watch_chromium.org, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, tburkard+watch_chromium.org, gavinp+prer_chromium.org, dominich+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove PrerenderCondition*. Cleanup: https://crrev.com/516443002/ obsoleted PrerenderCondition* classes. BUG=406583 Committed: https://crrev.com/3e537c867f91c5528744e1fbe7dde95d7568a45d Cr-Commit-Position: refs/heads/master@{#293151}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove two header includes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -189 lines) Patch
D chrome/browser/android/prerender_condition_platform.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/android/prerender_condition_platform.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/chromeos/prerender_condition_network.h View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/chromeos/prerender_condition_network.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/prerender/prerender_condition.h View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.h View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 4 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/prerender/prerender_manager_factory.cc View 1 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Bence
stevenjb@chromium.org: Please review changes in chrome/browser/chromeos, chrome/chrome_browser_chromeos.gypi. mmenke@chromium.org: Please review changes in chrome/browser/prerender. bauerb@chromium.org: chrome/browser/android.
6 years, 3 months ago (2014-08-29 20:59:59 UTC) #2
Bernhard Bauer
Trivially LGTM.
6 years, 3 months ago (2014-08-30 11:48:33 UTC) #3
mmenke
https://codereview.chromium.org/517843005/diff/1/chrome/browser/prerender/prerender_manager.cc File chrome/browser/prerender/prerender_manager.cc (left): https://codereview.chromium.org/517843005/diff/1/chrome/browser/prerender/prerender_manager.cc#oldcode320 chrome/browser/prerender/prerender_manager.cc:320: STLDeleteElements(&prerender_conditions_); Do we still need the stl_util header? https://codereview.chromium.org/517843005/diff/1/chrome/browser/prerender/prerender_manager_factory.cc ...
6 years, 3 months ago (2014-09-02 15:11:43 UTC) #4
Bence
stevenjb, mmenke: PTAL. https://codereview.chromium.org/517843005/diff/1/chrome/browser/prerender/prerender_manager.cc File chrome/browser/prerender/prerender_manager.cc (left): https://codereview.chromium.org/517843005/diff/1/chrome/browser/prerender/prerender_manager.cc#oldcode320 chrome/browser/prerender/prerender_manager.cc:320: STLDeleteElements(&prerender_conditions_); On 2014/09/02 15:11:43, mmenke wrote: ...
6 years, 3 months ago (2014-09-03 12:51:39 UTC) #5
mmenke
LGTM
6 years, 3 months ago (2014-09-03 14:17:20 UTC) #6
stevenjb
c/b/chromeos owner lgtm
6 years, 3 months ago (2014-09-03 15:26:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bnc@chromium.org/517843005/20001
6 years, 3 months ago (2014-09-03 15:41:56 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ef9ffdf494f998003e07b5e3f086c44f84b2d0bc
6 years, 3 months ago (2014-09-03 16:42:49 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:26:12 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3e537c867f91c5528744e1fbe7dde95d7568a45d
Cr-Commit-Position: refs/heads/master@{#293151}

Powered by Google App Engine
This is Rietveld 408576698