Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 517843003: Add tests to verify playback ends when audio/video durations differ. (Closed)

Created:
6 years, 3 months ago by scherkus (not reviewing)
Modified:
6 years, 3 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add tests to verify playback ends when audio/video durations differ. In preparation for changing how we compute media time, add some tests to verify the current behaviour. BUG=370634 Committed: https://crrev.com/d6f1e09b967d780c72d68fc1869a50ffdf74bd66 Cr-Commit-Position: refs/heads/master@{#292544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M media/filters/pipeline_integration_test.cc View 1 chunk +22 lines, -0 lines 0 comments Download
A + media/test/data/bear_audio_longer_than_video.ogv View Binary file 0 comments Download
A + media/test/data/bear_audio_shorter_than_video.ogv View Binary file 0 comments Download

Messages

Total messages: 7 (0 generated)
scherkus (not reviewing)
scherkus@chromium.org changed reviewers: + dalecurtis@chromium.org
6 years, 3 months ago (2014-08-29 00:38:26 UTC) #1
scherkus (not reviewing)
I couldn't find any existing tests for this scenario ... but it is indeed an ...
6 years, 3 months ago (2014-08-29 00:38:26 UTC) #2
DaleCurtis
lgtm, we have some pipeline tests around different start times, which has some implicit testing ...
6 years, 3 months ago (2014-08-29 00:52:10 UTC) #3
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 3 months ago (2014-08-29 00:53:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/517843003/1
6 years, 3 months ago (2014-08-29 00:54:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 505fb8a927fe5ff73c7541f10a28214a854b8a11
6 years, 3 months ago (2014-08-29 01:50:48 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:05:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6f1e09b967d780c72d68fc1869a50ffdf74bd66
Cr-Commit-Position: refs/heads/master@{#292544}

Powered by Google App Engine
This is Rietveld 408576698