Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 517813002: Keep a copy of page id in RenderViewHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index 78d6ed92a67f102a801ef286f337c7506a5c6b8c..35d316fd4293d24912c492a05f78004da4c51ac4 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -184,6 +184,7 @@ RenderViewHostImpl::RenderViewHostImpl(
instance_(static_cast<SiteInstanceImpl*>(instance)),
waiting_for_drag_context_response_(false),
enabled_bindings_(0),
+ page_id_(-1),
main_frame_routing_id_(main_frame_routing_id),
run_modal_reply_msg_(NULL),
run_modal_opener_id_(MSG_ROUTING_NONE),
@@ -1073,6 +1074,7 @@ void RenderViewHostImpl::OnRenderProcessGone(int status, int exit_code) {
}
void RenderViewHostImpl::OnUpdateState(int32 page_id, const PageState& state) {
+ CHECK_EQ(page_id_, page_id);
// Without this check, the renderer can trick the browser into using
// filenames it can't access in a future session restore.
if (!CanAccessFilesOfPageState(state)) {
@@ -1080,12 +1082,13 @@ void RenderViewHostImpl::OnUpdateState(int32 page_id, const PageState& state) {
return;
}
- delegate_->UpdateState(this, page_id, state);
+ delegate_->UpdateState(this, page_id_, state);
}
void RenderViewHostImpl::OnUpdateTargetURL(int32 page_id, const GURL& url) {
+ CHECK_EQ(page_id_, page_id);
if (IsRVHStateActive(rvh_state_))
- delegate_->UpdateTargetURL(page_id, url);
+ delegate_->UpdateTargetURL(page_id_, url);
// Send a notification back to the renderer that we are ready to
// receive more target urls.
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/browser/renderer_host/render_view_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698