Keep a copy of page id in RenderViewHost.

Keep a copy of page id in RenderViewHost.

This is an instrumented version of the patch that will be reverted in a few days. This is meant to catch crashes in edge cases and log enough for us to repro them.

BUG=407376
TEST=this may crash for a few people

Committed: https://crrev.com/6180ef0f7862e513b3c77c57df1185d3f6dcf085
Cr-Commit-Position: refs/heads/master@{#292572}

[Charlie Reis, 2014-08-28 22:09:57]

creis@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2014-08-28 22:09:58]

Yep, that will test our theory.  Either we'll get a stack trace from the
renderer confirming that an updated page ID is being sent before DidCommit (and
showing how it happens), or we'll continue to see the browser-side CHECKs and we
need to hunt down another lead.

LGTM.

[Avi (use Gerrit), 2014-08-28 23:29:18]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-08-28 23:30:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/avi@chromium.org/517813002/1

[commit-bot: I haz the power, 2014-08-29 00:02:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-29 00:05:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-29 00:05:22]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[Avi (use Gerrit), 2014-08-29 00:17:36]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-08-29 00:19:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/avi@chromium.org/517813002/20001

[commit-bot: I haz the power, 2014-08-29 03:50:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-29 04:23:08]

Committed patchset #2 (id:20001) as ab752e59a10a2a4c322ee7f6dbbb16a4fdb467e0

[Charlie Reis, 2014-08-29 23:54:42]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/526493004/ by creis@chromium.org.

The reason for reverting is: Crash data is coming in from the 39.0.2140.0
canary.  I'll revert this so that it doesn't continue reporting crashes over the
long weekend.

(Sadly, the crashes so far appear to be in the browser process and not the
renderer process, meaning we don't have a solid explanation yet.).

[commit-bot: I haz the power, 2014-09-10 03:06:22]

Patchset 2 (id:??) landed as
https://crrev.com/6180ef0f7862e513b3c77c57df1185d3f6dcf085
Cr-Commit-Position: refs/heads/master@{#292572}