Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: build/common.gypi

Issue 517803004: Reland https://codereview.chromium.org/298333007/: Enable mac_strip_release under ASan on OSX. Remo… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/asan.saves ('k') | chrome/app/app_asan.saves » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 71d96946c23dc04ce226b9944096b741a770b2dc..c48fc714f33d1b8301e73e39a9ba2a7622757185 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2141,9 +2141,8 @@
'clang%': 1,
}],
['asan==1 and OS=="mac"', {
- # TODO(glider): we do not strip ASan binaries until the dynamic ASan
- # runtime is fully adopted. See http://crbug.com/242503.
- 'mac_strip_release': 0,
+ # Strip and produce the .dSYM files.
+ 'mac_strip_release': 1,
}],
['tsan==1', {
'use_custom_libcxx%': 1,
@@ -4986,16 +4985,6 @@
],
},
],
- 'conditions': [
- ['asan==1', {
- 'variables': {
- 'asan_saves_file': 'asan.saves',
- },
- 'xcode_settings': {
- 'CHROMIUM_STRIP_SAVE_FILE': '<(asan_saves_file)',
- },
- }],
- ],
'target_conditions': [
['mac_pie==1 and release_valgrind_build==0', {
# Turn on position-independence (ASLR) for executables. When
@@ -5035,13 +5024,6 @@
# additional flags are added with STRIPFLAGS.
'STRIPFLAGS': '-x',
}], # _type=="shared_library" or _type=="loadable_module"
- ['_type=="executable"', {
- 'conditions': [
- ['asan==1', {
- 'STRIPFLAGS': '-s $(CHROMIUM_STRIP_SAVE_FILE)',
- }]
- ],
- }], # _type=="executable" and asan==1
], # target_conditions
}, # xcode_settings
}, # configuration "Release"
« no previous file with comments | « build/asan.saves ('k') | chrome/app/app_asan.saves » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698