content/renderer/media/audio_renderer_mixer_manager.cc - Issue 517793003: Reorder AudioMessageFilter shutdown. Remove spammy DCHECK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/audio_renderer_mixer_manager.cc

Issue 517793003: Reorder AudioMessageFilter shutdown. Remove spammy DCHECK. (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/audio_renderer_mixer_manager.cc

diff --git a/content/renderer/media/audio_renderer_mixer_manager.cc b/content/renderer/media/audio_renderer_mixer_manager.cc

index b2d743e0b96e6dd240ea4a7fa15c77b2ae3a049b..17b54b3be85b3b7d41532294197e646b421277a0 100644

--- a/content/renderer/media/audio_renderer_mixer_manager.cc

+++ b/content/renderer/media/audio_renderer_mixer_manager.cc

@@ -21,7 +21,8 @@ AudioRendererMixerManager::AudioRendererMixerManager(

}

AudioRendererMixerManager::~AudioRendererMixerManager() {

- DCHECK(mixers_.empty());

+ // ARM owners may be garbage collected objects. During process shutdown they

scherkus (not reviewing) 2014/09/05 23:04:59 s/ARM/whatever-ARM-stands-for/?

DaleCurtis 2014/09/05 23:09:35 Done.

+ // may be leaked, so, transitively, |mixers_| may leak as well.

}

media::AudioRendererMixerInput* AudioRendererMixerManager::CreateInput(

« no previous file with comments | « no previous file | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »