components/copresence/copresence_manager_impl.cc - Issue 517753002: Remove weak_ptr from CopresenceManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/copresence/copresence_manager_impl.cc

Issue 517753002: Remove weak_ptr from CopresenceManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/copresence/copresence_manager_impl.cc

diff --git a/components/copresence/copresence_manager_impl.cc b/components/copresence/copresence_manager_impl.cc

index 87df6c64a632028613d07201b8da050ab55aba69..397bcfc628213345cf529e6403f44461a21d1be4 100644

--- a/components/copresence/copresence_manager_impl.cc

+++ b/components/copresence/copresence_manager_impl.cc

@@ -22,7 +22,9 @@ PendingRequest::~PendingRequest() {

// Public methods

-CopresenceManagerImpl::~CopresenceManagerImpl() {}

+CopresenceManagerImpl::~CopresenceManagerImpl() {

+ init_callback_.Cancel();

Daniel Erat 2014/08/28 21:32:41 looking at CancelableCallback, i don't think you n

rkc 2014/08/28 21:51:50 Done.

// Returns false if any operations were malformed.

void CopresenceManagerImpl::ExecuteReportRequest(