Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 51773002: Add a libcap target to link against libcap2. (Closed)

Created:
7 years, 1 month ago by jln (very slow on Chromium)
Modified:
7 years, 1 month ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Visibility:
Public.

Description

Add a libcap target to link against libcap2. Targets which need to link with -lcap can now depend on libcap. BUG=312384 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231809

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move to respect alphabetical order. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M build/linux/system.gyp View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jln (very slow on Chromium)
Paweł: please take a look! I indeed up just treating it exactly like libresolv: it's ...
7 years, 1 month ago (2013-10-30 00:08:07 UTC) #1
Paweł Hajdan Jr.
LGTM with a comment https://codereview.chromium.org/51773002/diff/1/build/linux/system.gyp File build/linux/system.gyp (right): https://codereview.chromium.org/51773002/diff/1/build/linux/system.gyp#newcode887 build/linux/system.gyp:887: 'target_name': 'libcap', nit: Please keep ...
7 years, 1 month ago (2013-10-30 00:22:58 UTC) #2
jln (very slow on Chromium)
https://codereview.chromium.org/51773002/diff/1/build/linux/system.gyp File build/linux/system.gyp (right): https://codereview.chromium.org/51773002/diff/1/build/linux/system.gyp#newcode887 build/linux/system.gyp:887: 'target_name': 'libcap', On 2013/10/30 00:22:58, Paweł Hajdan Jr. wrote: ...
7 years, 1 month ago (2013-10-30 00:33:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/51773002/80001
7 years, 1 month ago (2013-10-30 06:12:32 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 10:38:17 UTC) #5
Message was sent while issue was closed.
Change committed as 231809

Powered by Google App Engine
This is Rietveld 408576698