Issue 517723002: MacViews: Get ImageTest to pass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 517723002: MacViews: Get ImageTest to pass (Closed)

Created:
6 years, 3 months ago by Andre

Modified:
6 years, 3 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, rsesek+watch_chromium.org, mac-views-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

MacViews: Get ImageTest to pass Mac does not use Skia image natively even if TOOLKIT_VIEWS=1. BUG=378134 Committed: https://crrev.com/3d2ccd9f5ec6bc9b7b283e9527ce1af83aa8e1a7 Cr-Commit-Position: refs/heads/master@{#292443}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	ui/gfx/image/image_unittest.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download

Total messages: 7 (0 generated)

Andre

rsesek@ PTAL. From what i can tell, only Mac and iOS use non-native platform image ...

6 years, 3 months ago (2014-08-28 18:46:30 UTC) #1

Robert Sesek

rsesek@chromium.org changed reviewers: + rsesek@chromium.org

6 years, 3 months ago (2014-08-28 18:47:50 UTC) #2

Robert Sesek

LGTM. Yes, this is right since Linux no longer uses GTK.

6 years, 3 months ago (2014-08-28 18:47:51 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andresantoso@chromium.org/517723002/1

6 years, 3 months ago (2014-08-28 18:51:27 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as e40296bda386de1960f5266203a85eb299be032b

6 years, 3 months ago (2014-08-28 19:22:29 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:01:33 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3d2ccd9f5ec6bc9b7b283e9527ce1af83aa8e1a7
Cr-Commit-Position: refs/heads/master@{#292443}