Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5124)

Unified Diff: chrome/browser/about_flags.cc

Issue 517713002: [Android] Add enhanced bookmark opt-in flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed an unused function IsUserSignedin Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/bookmarks/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 51672bcd2f54b0d96c361e8918c8c8231070add1..9736f1a614fbd1722daae4ed77177d85f306adf1 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -2011,6 +2011,10 @@ void GetSanitizedEnabledFlags(
bool SkipConditionalExperiment(const Experiment& experiment) {
if (experiment.internal_name ==
std::string("enhanced-bookmarks-experiment")) {
+#if defined(OS_ANDROID)
+ // On Android, user can opt in.
+ return false;
+#else
CommandLine* command_line = CommandLine::ForCurrentProcess();
// Dont't skip experiment if it has non default value.
// It means user selected it.
@@ -2018,7 +2022,9 @@ bool SkipConditionalExperiment(const Experiment& experiment) {
return false;
return !IsEnhancedBookmarksExperimentEnabled();
+#endif
}
+
if ((experiment.internal_name == std::string("manual-enhanced-bookmarks")) ||
(experiment.internal_name ==
std::string("manual-enhanced-bookmarks-optout"))) {
« no previous file with comments | « no previous file | chrome/browser/bookmarks/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698