Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 517673002: Fix test failures after r23492. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger
Modified:
6 years, 3 months ago
Reviewers:
vogelheim
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix test failures after r23492. R=vogelheim@chromium.org TEST=cctest/test-run-properties/TypedArrayLoad Committed: https://code.google.com/p/v8/source/detail?r=23498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-properties.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
Some platforms just don't take kindly to positional arguments in format strings.
6 years, 3 months ago (2014-08-28 17:15:09 UTC) #1
vogelheim
lgtm Oh, these modernist non-Posix extensions...
6 years, 3 months ago (2014-08-28 17:28:03 UTC) #2
Michael Starzinger
6 years, 3 months ago (2014-08-28 17:29:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23498 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698