Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 51763009: Add OVERRIDE where possible in HTMLMediaElement and children (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
Reviewers:
Mike West
CC:
blink-reviews, nessy, philipj_slow, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@indentcomments
Visibility:
Public.

Description

Add OVERRIDE where possible in HTMLMediaElement and children Some of the places where it wasn't added are in order, but some of them simply shouldn't be virtual and will be dealt with later. BUG=313702 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161068

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M Source/core/html/HTMLAudioElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.h View 6 chunks +20 lines, -20 lines 0 comments Download
M Source/core/html/HTMLVideoElement.h View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
7 years, 1 month ago (2013-10-31 14:54:50 UTC) #1
Mike West
On 2013/10/31 14:54:50, philipj wrote: LGTM. If these methods aren't being overridden by subclasses (e.g. ...
7 years, 1 month ago (2013-10-31 15:01:38 UTC) #2
Mike West
On 2013/10/31 15:01:38, Mike West wrote: > On 2013/10/31 14:54:50, philipj wrote: > > LGTM. ...
7 years, 1 month ago (2013-10-31 15:11:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/51763009/1
7 years, 1 month ago (2013-10-31 15:16:01 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 16:42:46 UTC) #5
Message was sent while issue was closed.
Change committed as 161068

Powered by Google App Engine
This is Rietveld 408576698