Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Unified Diff: Source/core/html/MediaController.cpp

Issue 517593003: Allow HTMLMediaElement.currentTime to be set before the transition to HAVE_METADATA (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: adding check for noSeekRequired Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/MediaController.cpp
diff --git a/Source/core/html/MediaController.cpp b/Source/core/html/MediaController.cpp
index 8c229c9450b0553b561cd183fcec3bcc33263fc7..23a91ca67d9ad6c16b9a72751e28a4688424c8e3 100644
--- a/Source/core/html/MediaController.cpp
+++ b/Source/core/html/MediaController.cpp
@@ -158,7 +158,7 @@ double MediaController::currentTime() const
return m_position;
}
-void MediaController::setCurrentTime(double time, ExceptionState& exceptionState)
+void MediaController::setCurrentTime(double time)
{
// When the user agent is to seek the media controller to a particular new playback position,
// it must follow these steps:
@@ -175,7 +175,7 @@ void MediaController::setCurrentTime(double time, ExceptionState& exceptionState
// Seek each slaved media element to the new playback position relative to the media element timeline.
for (MediaElementSequence::const_iterator it = m_mediaElements.begin(); it != m_mediaElements.end(); ++it)
- (*it)->seek(time, exceptionState);
+ (*it)->seek(time);
scheduleTimeupdateEvent();
}
@@ -484,7 +484,7 @@ void MediaController::bringElementUpToSpeed(HTMLMediaElement* element)
// When the user agent is to bring a media element up to speed with its new media controller,
// it must seek that media element to the MediaController's media controller position relative
// to the media element's timeline.
- element->seek(currentTime(), IGNORE_EXCEPTION);
+ element->seek(currentTime());
// Update volume to take controller volume and mute into account.
element->updateVolume();

Powered by Google App Engine
This is Rietveld 408576698