Source/core/html/shadow/MediaControlElements.cpp - Issue 517593003: Allow HTMLMediaElement.currentTime to be set before the transition to HAVE_METADATA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/MediaControlElements.cpp

Issue 517593003: Allow HTMLMediaElement.currentTime to be set before the transition to HAVE_METADATA (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/shadow/MediaControlElements.cpp

diff --git a/Source/core/html/shadow/MediaControlElements.cpp b/Source/core/html/shadow/MediaControlElements.cpp

index 170b04b70f88b11f5c73c640e6d03362ecf3708f..9a184f89efd4b4c5a0acac0047e90323cfed540a 100644

--- a/Source/core/html/shadow/MediaControlElements.cpp

+++ b/Source/core/html/shadow/MediaControlElements.cpp

@@ -407,7 +407,7 @@ void MediaControlTimelineElement::defaultEventHandler(Event* event)

// FIXME: This will need to take the timeline offset into consideration

// once that concept is supported, see https://crbug.com/312699

if (mediaElement().controller())

- mediaElement().controller()->setCurrentTime(time, IGNORE_EXCEPTION);

+ mediaElement().controller()->setCurrentTime(time);

else

mediaElement().setCurrentTime(time, IGNORE_EXCEPTION);

}

« no previous file with comments | « Source/core/html/MediaController.idl ('k') | no next file » | no next file with comments »