Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

Issue 517573004: android: Add browser type for webview shell to telemetry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@awshell
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
index 32349098f18a8af3322ae54f53c46b333b1b8761..285e41e758ea8a07bd796c0dc5d5cf2af37a53c6 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
@@ -133,12 +133,12 @@ class ChromeShellBackendSettings(AndroidBrowserBackendSettings):
def GetDevtoolsRemotePort(self):
return 'localabstract:chrome_shell_devtools_remote'
-
class WebviewBackendSettings(AndroidBrowserBackendSettings):
- def __init__(self, adb, package):
+ def __init__(self, adb, package,
+ activity='org.chromium.telemetry_shell.TelemetryActivity'):
super(WebviewBackendSettings, self).__init__(
adb=adb,
- activity='org.chromium.telemetry_shell.TelemetryActivity',
+ activity=activity,
cmdline_file='/data/local/tmp/webview-command-line',
package=package,
pseudo_exec_name='webview',
@@ -166,6 +166,12 @@ class WebviewBackendSettings(AndroidBrowserBackendSettings):
'Timeout waiting for PID.')
return 'localabstract:webview_devtools_remote_%s' % str(pid)
+class WebviewShellBackendSettings(WebviewBackendSettings):
+ def __init__(self, adb, package):
+ super(WebviewShellBackendSettings, self).__init__(
+ adb=adb,
+ activity='org.chromium.android_webview.shell.AwShellActivity',
+ package=package)
class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
"""The backend for controlling a browser instance running on Android."""
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698