Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: dart/sdk/lib/io/websocket_impl.dart

Issue 517513002: Bugfix in dart:io's WebSocketTransformer implementation, correctly test async behaviour of websocke… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/tests/standalone/io/web_socket_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/sdk/lib/io/websocket_impl.dart
diff --git a/dart/sdk/lib/io/websocket_impl.dart b/dart/sdk/lib/io/websocket_impl.dart
index 708af8aeeb8e1032f01b43394312827b2ee32a2c..872cd321ad7b223deadefd840311925fe9f123b8 100644
--- a/dart/sdk/lib/io/websocket_impl.dart
+++ b/dart/sdk/lib/io/websocket_impl.dart
@@ -372,6 +372,8 @@ class _WebSocketTransformerImpl implements WebSocketTransformer {
_upgrade(request, _protocolSelector)
.then((WebSocket webSocket) => _controller.add(webSocket))
.catchError(_controller.addError);
+ }, onDone: () {
+ _controller.close();
});
return _controller.stream;
« no previous file with comments | « no previous file | dart/tests/standalone/io/web_socket_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698