content/browser/service_worker/service_worker_registration_unittest.cc - Issue 517493002: ServiceWorker: Update the install sequence as per the latest spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration_unittest.cc

Issue 517493002: ServiceWorker: Update the install sequence as per the latest spec (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment fix (+rebase) Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_registration_handle.cc ('k') | content/child/service_worker/service_worker_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration_unittest.cc

diff --git a/content/browser/service_worker/service_worker_registration_unittest.cc b/content/browser/service_worker/service_worker_registration_unittest.cc

index 1550d1ec6c86ba42202b22af9c7603f95808c5a6..c3897748059990ed696b9f7a74e5ad9a74f179fc 100644

--- a/content/browser/service_worker/service_worker_registration_unittest.cc

+++ b/content/browser/service_worker/service_worker_registration_unittest.cc

@@ -61,6 +61,16 @@ class ServiceWorkerRegistrationTest : public testing::Test {

NOTREACHED();

}

+ virtual void OnRegistrationFinishedUninstalling(

+ ServiceWorkerRegistration* registration) OVERRIDE {

+ NOTREACHED();

+ }

+ virtual void OnUpdateFound(

+ ServiceWorkerRegistration* registration) OVERRIDE {

+ NOTREACHED();

+ }

void Reset() {

observed_registration_ = NULL;

observed_changed_mask_ = ChangedVersionAttributesMask();