Issue 517453003: Use .equals() for string comparisons in ModelType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 517453003: Use .equals() for string comparisons in ModelType. (Closed)

Created:
6 years, 3 months ago by Bernhard Bauer

Modified:
6 years, 3 months ago

Reviewers:
vabr (Chromium)

CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Use .equals() for string comparisons in ModelType. This fixes a FindBugs warning. NOTRY=true BUG=none Committed: https://crrev.com/d803b15e46194fb98ca0667b068c539c0880ffed Cr-Commit-Position: refs/heads/master@{#292364}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (0 generated)

Bernhard Bauer

bauerb@chromium.org changed reviewers: + vabr@chromium.org

6 years, 3 months ago (2014-08-28 10:45:18 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/517453003/1

6 years, 3 months ago (2014-08-28 11:08:11 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 9bccbca4f9902206c6159dc27a90704b0834ac1f

6 years, 3 months ago (2014-08-28 11:08:45 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:58:59 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d803b15e46194fb98ca0667b068c539c0880ffed
Cr-Commit-Position: refs/heads/master@{#292364}