Issue 517453002: Disable ProxyConfigServiceImplTest.* under valgrind.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 517453002: Disable ProxyConfigServiceImplTest.* under valgrind. (Closed)

Created:
6 years, 3 months ago by benwells

Modified:
6 years, 3 months ago

Reviewers:
zhaoqin1

CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, zel

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable ProxyConfigServiceImplTest.* under valgrind. NOTRY=true TBR=zhaoqin BUG=408013 Committed: https://crrev.com/29b6cd7609de0831b6b2641187704b4076b41fe1 Cr-Commit-Position: refs/heads/master@{#292328}

Patch Set 1 #

Patch Set 2 : Oops #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tools/valgrind/gtest_exclude/unit_tests.gtest.txt	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

benwells

benwells@chromium.org changed reviewers: + zhaoqin@chromium.org

6 years, 3 months ago (2014-08-28 05:02:12 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/517453002/20001

6 years, 3 months ago (2014-08-28 05:03:41 UTC) #4

commit-bot: I haz the power

Committed patchset #2 (id:20001) as e2df71f1bdd20a6e5967729ef259274e6e8ec723

6 years, 3 months ago (2014-08-28 05:38:10 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:57:50 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/29b6cd7609de0831b6b2641187704b4076b41fe1
Cr-Commit-Position: refs/heads/master@{#292328}

Expand Messages | Collapse Messages