Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: Source/core/accessibility/AXNodeObject.cpp

Issue 51743003: Treat inert nodes as aria-hidden instead of aria-disabled. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/accessibility/inert-node-is-hidden-expected.txt ('k') | Source/core/accessibility/AXObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/accessibility/AXNodeObject.cpp
diff --git a/Source/core/accessibility/AXNodeObject.cpp b/Source/core/accessibility/AXNodeObject.cpp
index 2d5b5f4fa0838cc41df4ecf74d763745f748428c..0cb346920078747a73eb434eb5ff7f9dbfb2c473 100644
--- a/Source/core/accessibility/AXNodeObject.cpp
+++ b/Source/core/accessibility/AXNodeObject.cpp
@@ -669,7 +669,7 @@ bool AXNodeObject::isEnabled() const
if (!node || !node->isElementNode())
return true;
- return !node->isInert() && !toElement(node)->isDisabledFormControl();
+ return !toElement(node)->isDisabledFormControl();
}
bool AXNodeObject::isIndeterminate() const
@@ -1090,7 +1090,7 @@ static bool shouldUseAccessiblityObjectInnerText(AXObject* obj)
// containers with lots of children.
// Skip hidden children
- if (equalIgnoringCase(obj->getAttribute(aria_hiddenAttr), "true"))
+ if (obj->isInertOrAriaHidden())
return false;
// Skip focusable children, so we don't include the text of links and controls.
« no previous file with comments | « LayoutTests/accessibility/inert-node-is-hidden-expected.txt ('k') | Source/core/accessibility/AXObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698