LayoutTests/accessibility/inert-node-is-hidden.html - Issue 51743003: Treat inert nodes as aria-hidden instead of aria-disabled.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/accessibility/inert-node-is-hidden.html

Issue 51743003: Treat inert nodes as aria-hidden instead of aria-disabled. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rename, expectations, etc Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/accessibility/inert-node-is-disabled-expected.txt ('k') | LayoutTests/accessibility/inert-node-is-hidden-expected.txt » ('j') | Source/core/accessibility/AXObject.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

	2 <html>

	3 <head>

	4 <script src="../fast/js/resources/js-test-pre.js"></script>

	5 </head>

	6 <body id="body">

	7 This content should not be exposed to AT when a modal dialog is open.

	8 <div>

	9 <input title="input" id="input" type="text">

	10 </div>

	11 <dialog title="dialog" id="dialog">Howdy</dialog>

	12

	13 <script>

	14 description("This tests that inert elements are not in the AT tree.");

	15

	16 function treeContainsText(node, text) {

	17 if (node.stringValue.indexOf(text) > 0)

	18 return true;

	19 for (i = 0; i < node.childrenCount; i++) {

	20 if (treeContainsText(node.childAtIndex(i), text))

	21 return true;

	22 }

	23 return false;

	24 }

	25

	26 if (window.accessibilityController) {

	27 document.body.focus();

	28 webArea = accessibilityController.focusedElement;

	29

	30 shouldBeNonNull("accessibilityController.accessibleElementById('input')");

	31 shouldBeTrue("treeContainsText(webArea, 'This content should not be exposed to AT when a modal dialog is open')");
	dmazzoni 2013/10/30 23:32:22 A simpler way to test this is accessibilityControl A simpler way to test this is accessibilityController.accessibleElementById(id) falken 2013/10/31 02:27:40 I wanted to ensure it works for an anon child of b Show quoted text On 2013/10/30 23:32:22, Dominic Mazzoni wrote: > A simpler way to test this is accessibilityController.accessibleElementById(id) I wanted to ensure it works for an anon child of body, and it looked a bit tricky to navigate exactly to the text using childAtIndex (it's two levels deep, and its position would change when the dialog is opened). So I just did a brute force search of the tree.
	32

	33 document.querySelector('dialog').showModal();

	34 shouldBeNull("accessibilityController.accessibleElementById('input')");

	35 shouldBeFalse("treeContainsText(webArea, 'This content should not be exposed to AT when a modal dialog is open')");

	36

	37 document.querySelector('dialog').close();

	38 shouldBeNonNull("accessibilityController.accessibleElementById('input')");

	39 shouldBeTrue("treeContainsText(webArea, 'This content should not be exposed to AT when a modal dialog is open')");

	40 }

	41 </script>

	42 <script src="../fast/js/resources/js-test-post.js"></script>

	43 </body>

	44 </html>

OLD	NEW