Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2738)

Unified Diff: chrome/browser/resources/options/chromeos/internet_detail.js

Issue 517413002: Compile chrome://settings, part 1: remove all warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master
Patch Set: s/event/Event/ Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/chromeos/internet_detail.js
diff --git a/chrome/browser/resources/options/chromeos/internet_detail.js b/chrome/browser/resources/options/chromeos/internet_detail.js
index 69f49886486672589244082d064dd5a420d19640..e3574440eaa749b57aee4395019cdb26bac64b82 100644
--- a/chrome/browser/resources/options/chromeos/internet_detail.js
+++ b/chrome/browser/resources/options/chromeos/internet_detail.js
@@ -29,11 +29,11 @@ cr.define('options.internet', function() {
}
}
- /*
+ /**
* Helper function to update the properties of the data object from the
* properties in the update object.
- * @param {object} data object to update.
- * @param {object} object containing the updated properties.
+ * @param {Object} data Object to update.
+ * @param {Object} update Object containing the updated properties.
*/
function updateDataObject(data, update) {
for (var prop in update) {
@@ -381,7 +381,7 @@ cr.define('options.internet', function() {
/**
* Handler for when the name server selection changes.
- * @param {Event} e The click event.
+ * @param {Event} event The click event.
* @private
*/
handleNameServerTypeChange_: function(event) {
@@ -393,8 +393,8 @@ cr.define('options.internet', function() {
* Creates an indicator event for controlled properties using
* the same dictionary format as CoreOptionsHandler::CreateValueForPref.
* @param {string} name The name for the Event.
- * @param {Object} propData Property dictionary with |value|, |controlledBy|
- * and |recommendedValue| properties set.
+ * @param {!{value: *, controlledBy: *, recommendedValue: *}} propData
+ * Property dictionary,
* @private
*/
createControlledEvent_: function(name, propData) {

Powered by Google App Engine
This is Rietveld 408576698