Making suggestion popup scrollable in landscape mode

chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.shell.omnibox;
 
 import android.content.Context;
+import android.graphics.Rect;
 import android.os.Handler;
 import android.text.Editable;
 import android.text.TextUtils;
 import android.text.TextWatcher;
 import android.view.View;
 import android.view.View.OnLayoutChangeListener;
 import android.widget.AdapterView;
 import android.widget.AdapterView.OnItemClickListener;
 import android.widget.ListPopupWindow;
 import android.widget.PopupWindow.OnDismissListener;
 import android.widget.TextView;
 
 import org.chromium.chrome.browser.omnibox.AutocompleteController;
 import org.chromium.chrome.browser.omnibox.AutocompleteController.OnSuggestionsReceivedListener;
 import org.chromium.chrome.browser.omnibox.OmniboxSuggestion;
+import org.chromium.chrome.shell.ChromeShellActivity;
 import org.chromium.chrome.shell.ChromeShellToolbar;
 import org.chromium.chrome.shell.R;
 
 import java.util.List;
 
 /**
  * Displays suggestions for the text that is entered to the ChromeShell URL field.
  */
 public class SuggestionPopup implements OnSuggestionsReceivedListener, TextWatcher {
     private static final long SUGGESTION_START_DELAY_MS = 30;
@@ skipping 17 matching lines @@
         mContext = context;
         mUrlField = urlField;
         mToolbar = toolbar;
         mAutocomplete = new AutocompleteController(this);
         OnLayoutChangeListener listener = new OnLayoutChangeListener() {
             @Override
             public void onLayoutChange(View v, int left, int top, int right, int bottom,
                     int oldLeft, int oldTop, int oldRight, int oldBottom) {
                 if (mSuggestionsPopup == null || !mSuggestionsPopup.isShowing()) return;
                 mSuggestionsPopup.setWidth(mUrlField.getWidth());
+                mSuggestionsPopup.setHeight(getSuggestionPopupHeight());
                 mSuggestionsPopup.show();
             }
         };
         mUrlField.addOnLayoutChangeListener(listener);
     }
 
     private void navigateToSuggestion(int position) {
         mToolbar.getCurrentTab().loadUrlWithSanitization(
                 mSuggestionArrayAdapter.getItem(position).getUrl());
         mUrlField.clearFocus();
@@ skipping 21 matching lines @@
      * Signals the autocomplete controller to stop generating suggestions and
      * cancels the queued task to start the autocomplete controller, if any.
      *
      * @param clear Whether to clear the most recent autocomplete results.
      */
     private void stopAutocomplete(boolean clear) {
         if (mAutocomplete != null) mAutocomplete.stop(clear);
         if (mRequestSuggestions != null) mRequestSuggestions = null;
     }
 
+    private int getSuggestionPopupHeight() {
+        Rect appRect = new Rect();
+        ((ChromeShellActivity)mContext).getWindow().getDecorView().
+                getWindowVisibleDisplayFrame(appRect);
+        int dropDownItemHeight = mContext.getResources().
+                getDimensionPixelSize(R.dimen.dropdown_item_height);
+        int height = dropDownItemHeight;

[Bernhard Bauer, 2014/09/01 13:45:10]

This value isn't used (and the variable only inside of the if-statement), so
remove this line and declare the variable on line 112.

[ankit, 2014/09/02 04:20:11]

Done.

+        if (mSuggestionsPopup != null && mSuggestionsPopup.getListView() != null) {
+            height = mSuggestionsPopup.getListView().getCount() * dropDownItemHeight;

[Bernhard Bauer, 2014/09/01 13:45:10]

Instead of asking the view for its number of items, you could ask the adapter,
which actually holds the items.

[ankit, 2014/09/02 04:20:11]

Stored value in a local variable and using it instead of asking the view.

+            if (appRect.height() > height)

[Bernhard Bauer, 2014/09/01 13:45:10]

I don't quite understand this. If the height of the whole list is less than the
app window, we return the list height, but otherwise we return the app window
height, but minus the height of one item. Don't we also need to subtract that
one item here?

[ankit, 2014/09/02 04:20:11]

Done.

+                return height;
+        }
+        //maintaining margin height of dropdDownItemHeight

[Bernhard Bauer, 2014/09/01 13:45:10]

Add a space after //, capitalize the first character of the sentence, put
|dropDownItemHeight| between pipe symbols, spell it correctly, and end the
sentence with a period please.

[ankit, 2014/09/02 04:20:11]

Done.

+        return appRect.height() - dropDownItemHeight;
+    }
+
     // OnSuggestionsReceivedListener implementation
 
     @Override
     public void onSuggestionsReceived(List<OmniboxSuggestion> suggestions,
             String inlineAutocompleteText) {
         if (!mUrlField.isFocused() || suggestions.isEmpty())
             return;
         if (mSuggestionsPopup == null) {
             mSuggestionsPopup = new ListPopupWindow(
                     mContext, null, android.R.attr.autoCompleteTextViewStyle);
             mSuggestionsPopup.setOnDismissListener(new OnDismissListener() {
                 @Override
                 public void onDismiss() {
                     mHasStartedNewOmniboxEditSession = false;
                     mSuggestionArrayAdapter = null;
                 }
             });
         }
+        mSuggestionsPopup.setInputMethodMode(ListPopupWindow.INPUT_METHOD_NEEDED);
         mSuggestionsPopup.setWidth(mUrlField.getWidth());
         mSuggestionArrayAdapter =
                 new SuggestionArrayAdapter(mContext, R.layout.dropdown_item, suggestions);
+        mSuggestionsPopup.setHeight(getSuggestionPopupHeight());
         mSuggestionsPopup.setAdapter(mSuggestionArrayAdapter);
         mSuggestionsPopup.setAnchorView(mUrlField);
         mSuggestionsPopup.setOnItemClickListener(new OnItemClickListener() {
             @Override
             public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
                 navigateToSuggestion(position);
             }
         });
         mSuggestionsPopup.show();
     }
@@ skipping 29 matching lines @@
 
     @Override
     public void beforeTextChanged(CharSequence s, int start, int count, int after) {
         mRequestSuggestions = null;
     }
 
     @Override
     public void onTextChanged(CharSequence s, int start, int before, int count) {
     }
 }