runtime/vm/stub_code_arm64.cc - Issue 517383005: VM: Clean up generated code for NoSuchMethod invocation of closures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_arm64.cc

Issue 517383005: VM: Clean up generated code for NoSuchMethod invocation of closures. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stub_code_arm64.cc

===================================================================

--- runtime/vm/stub_code_arm64.cc (revision 39693)

+++ runtime/vm/stub_code_arm64.cc (working copy)

@@ -1241,7 +1241,6 @@

// Input parameters:

// LR : return address.

// SP : address of last argument.

-// R5: inline cache data object.

// R4: arguments descriptor array.

void StubCode::GenerateCallNoSuchMethodFunctionStub(Assembler* assembler) {

__ EnterStubFrame(true);

@@ -1257,15 +1256,15 @@

// Push arguments descriptor array.

__ PushObject(Object::null_object(), PP);

__ Push(R6);

- __ Push(R5);

__ Push(R4);

// R2: Smi-tagged arguments array length.

PushArgumentsArray(assembler);

- __ CallRuntime(kInvokeNoSuchMethodFunctionRuntimeEntry, 4);

+ const intptr_t kNumArgs = 3;

+ __ CallRuntime(kInvokeNoSuchMethodFunctionRuntimeEntry, kNumArgs);

// Remove arguments.

- __ Drop(4);

+ __ Drop(kNumArgs);

__ Pop(R0); // Get result into R0.

Vyacheslav Egorov (Google) 2014/09/02 22:28:04 something is off here with amount of pushed args /

Florian Schneider 2014/09/03 09:05:00 I'm sure PushArgumentsArray is the missing piece h

__ LeaveStubFrame();

__ ret();

« runtime/vm/stub_code_arm.cc ('K') | « runtime/vm/stub_code_arm.cc ('k') | runtime/vm/stub_code_ia32.cc » ('j') | runtime/vm/stub_code_x64.cc » ('J')