Add GYP dependencies for the ASan RTL in the component build mode.

Add GYP dependencies for the ASan RTL in the component build mode

BUG=345874
NOTRY=true

Committed: https://crrev.com/6e2f3e261755cdc688ac0e0492655695e7e6f73d
Cr-Commit-Position: refs/heads/master@{#292655}

[Timur Iskhodzhanov, 2014-08-29 16:39:59]

timurrrr@chromium.org changed reviewers:
+ hans@chromium.org

[hans, 2014-08-29 16:43:20]

https://codereview.chromium.org/517383003/diff/1/build/win/asan.gyp
File build/win/asan.gyp (right):

https://codereview.chromium.org/517383003/diff/1/build/win/asan.gyp#newcode22
build/win/asan.gyp:22:
'../../third_party/llvm-build/Release+Asserts/bin/clang_rt.asan_dynamic-i386.dll',
Can we use clang_make_dir here? That makes it possible to use this stuff with a
local LLVM build in an alternative location.

[Timur Iskhodzhanov, 2014-08-29 16:48:25]

Good idea!
Done, PTAL.

[+cc: glider@ in case he wants to do the same on Mac]

[Timur Iskhodzhanov, 2014-08-29 16:49:11]

https://codereview.chromium.org/517383003/diff/1/build/win/asan.gyp
File build/win/asan.gyp (right):

https://codereview.chromium.org/517383003/diff/1/build/win/asan.gyp#newcode22
build/win/asan.gyp:22:
'../../third_party/llvm-build/Release+Asserts/bin/clang_rt.asan_dynamic-i386.dll',
On 2014/08/29 16:43:19, hans wrote:
> Can we use clang_make_dir here? That makes it possible to use this stuff with
a
> local LLVM build in an alternative location.

Done.

[hans, 2014-08-29 16:50:17]

lgtm

[Timur Iskhodzhanov, 2014-08-29 16:50:33]

The CQ bit was checked by timurrrr@chromium.org

[commit-bot: I haz the power, 2014-08-29 16:51:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/timurrrr@chromium.org/517383003/20001

[commit-bot: I haz the power, 2014-08-29 16:52:06]

Committed patchset #2 (id:20001) as 37524f69ba5ca2a389e334f2442d391a5c8c9729

[hans, 2014-08-29 16:57:21]

I should have noticed this in the review, but for the future I don't think
NOTRY=true is appropriate for changes that touch common.gypi, because that can
break a lot of stuff.

[Timur Iskhodzhanov, 2014-08-29 17:02:10]

Oh, that's a bad habit of me to add that line without thinking each time.
Thanks for pointing out! :-/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-09-10 03:09:23]

Patchset 2 (id:??) landed as
https://crrev.com/6e2f3e261755cdc688ac0e0492655695e7e6f73d
Cr-Commit-Position: refs/heads/master@{#292655}