Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 517373002: Mojo: Remove the STATE_WAIT_LOCAL_DETACH_AND_REMOTE_REMOVE_ACK endpoint state. (Closed)

Created:
6 years, 3 months ago by viettrungluu
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Remove the STATE_WAIT_LOCAL_DETACH_AND_REMOTE_REMOVE_ACK endpoint state. And add a long explanatory comment about how things are shut down. R=darin@chromium.org Committed: https://crrev.com/ac4bd76186fe18f358f95f1e3057f1f720795386 Cr-Commit-Position: refs/heads/master@{#292670}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -5 lines) Patch
M mojo/system/channel.h View 2 chunks +64 lines, -2 lines 0 comments Download
M mojo/system/channel.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
6 years, 3 months ago (2014-08-29 16:07:22 UTC) #1
darin (slow to review)
You would make Brett proud. LGTM
6 years, 3 months ago (2014-08-29 17:18:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/517373002/1
6 years, 3 months ago (2014-08-29 18:04:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as f00efdc19c080d2fe5105b957262c774f6a98449
6 years, 3 months ago (2014-08-29 18:39:31 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:10:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac4bd76186fe18f358f95f1e3057f1f720795386
Cr-Commit-Position: refs/heads/master@{#292670}

Powered by Google App Engine
This is Rietveld 408576698