Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 517363002: Fix a memory leak in MidiManagerAlsa initialization. (Closed)

Created:
6 years, 3 months ago by babu
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, yukawa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix a memory leak in MidiManagerAlsa initialization. Call snd_ctl_close() to free all the resources allocated with the control handle. BUG=409016 Committed: https://crrev.com/673572dd420381236cc66d46bf10aa9f1ccfc58e Cr-Commit-Position: refs/heads/master@{#292875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/midi/midi_manager_alsa.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
babu
6 years, 3 months ago (2014-08-29 16:52:40 UTC) #2
Takashi Toyoshima
lgtm Thank you for reporting and fixing this! It seems that this error can not ...
6 years, 3 months ago (2014-09-01 13:05:44 UTC) #4
babu
@toyoshim, thanks for review.
6 years, 3 months ago (2014-09-01 13:57:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarsana.nagineni@intel.com/517363002/1
6 years, 3 months ago (2014-09-01 13:57:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8fb3c7a3c1a8c1d72810c88364350787b4798738
6 years, 3 months ago (2014-09-01 14:53:39 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:16:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/673572dd420381236cc66d46bf10aa9f1ccfc58e
Cr-Commit-Position: refs/heads/master@{#292875}

Powered by Google App Engine
This is Rietveld 408576698