mojo: Starting generator for python bindings.

mojo: Starting generator for python bindings.

This generates constants for the python bindings.

R=pkl@chromium.org,cmasone@chromium.org

Committed: https://crrev.com/352a3ed73bb3f015a9db054a3d82820a569b94b6
Cr-Commit-Position: refs/heads/master@{#293105}

[pkl (ping after 24h if needed), 2014-09-01 12:52:03]

Here's a quick first pass. Not real sure what generated the not-to-commit/
files. I will look at this again.

https://codereview.chromium.org/517353002/diff/1/mojo/public/tools/bindings/g...
File mojo/public/tools/bindings/generators/mojom_python_generator.py (right):

https://codereview.chromium.org/517353002/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/mojom_python_generator.py:14: def
NameToComponent(name):
style: Function names should be name_to_component().

https://codereview.chromium.org/517353002/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/mojom_python_generator.py:27: return
''.join([CapitalizeFirst(x) for x in NameToComponent(name)])
why not just use x.capitalize() ? No need to define CapitalizeFirst().

https://codereview.chromium.org/517353002/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/mojom_python_generator.py:43: raise
Exception("Unexpected element: " % element)
style: Please use " and ' for string constants consistently.

https://codereview.chromium.org/517353002/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/mojom_python_generator.py:63: if
token.value == "double.NEGATIVE_INFINITY" or \
style: do not use backslash for continuation. Use:

  if (foo == a_long_value or
      bar == some_other_long_value):
    blah()

https://codereview.chromium.org/517353002/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/mojom_python_generator.py:91:
self.Write(self.GeneratePythonModule(), "%s.py" %
self.module.name.replace('.mojom', '_mojom'))
line length > 80

https://codereview.chromium.org/517353002/diff/1/mojo/python/tests/bindings_c...
File mojo/python/tests/bindings_constants_unittest.py (right):

https://codereview.chromium.org/517353002/diff/1/mojo/python/tests/bindings_c...
mojo/python/tests/bindings_constants_unittest.py:22:
self.assertTrue(math.isnan(sample_service_mojom.DOUBLE_NA_N))
Shouldn't DOUBLE_NA_N be DOUBLE_NAN instead?

[qsr, 2014-09-01 14:19:39]

https://chromiumcodereview.appspot.com/517353002/diff/1/mojo/public/tools/bin...
File mojo/public/tools/bindings/generators/mojom_python_generator.py (right):

https://chromiumcodereview.appspot.com/517353002/diff/1/mojo/public/tools/bin...
mojo/public/tools/bindings/generators/mojom_python_generator.py:14: def
NameToComponent(name):
On 2014/09/01 12:52:02, pklpkl wrote:
> style: Function names should be name_to_component().

 The style of all the python files in mojo/public/tools/bindings/generators use
UpperCamelCase for function names.

https://chromiumcodereview.appspot.com/517353002/diff/1/mojo/public/tools/bin...
mojo/public/tools/bindings/generators/mojom_python_generator.py:27: return
''.join([CapitalizeFirst(x) for x in NameToComponent(name)])
On 2014/09/01 12:52:02, pklpkl wrote:
> why not just use x.capitalize() ? No need to define CapitalizeFirst().

Done.

https://chromiumcodereview.appspot.com/517353002/diff/1/mojo/public/tools/bin...
mojo/public/tools/bindings/generators/mojom_python_generator.py:43: raise
Exception("Unexpected element: " % element)
On 2014/09/01 12:52:02, pklpkl wrote:
> style: Please use " and ' for string constants consistently.

Done.

https://chromiumcodereview.appspot.com/517353002/diff/1/mojo/public/tools/bin...
mojo/public/tools/bindings/generators/mojom_python_generator.py:63: if
token.value == "double.NEGATIVE_INFINITY" or \
On 2014/09/01 12:52:02, pklpkl wrote:
> style: do not use backslash for continuation. Use:
> 
>   if (foo == a_long_value or
>       bar == some_other_long_value):
>     blah()

Done.

https://chromiumcodereview.appspot.com/517353002/diff/1/mojo/public/tools/bin...
mojo/public/tools/bindings/generators/mojom_python_generator.py:91:
self.Write(self.GeneratePythonModule(), "%s.py" %
self.module.name.replace('.mojom', '_mojom'))
On 2014/09/01 12:52:02, pklpkl wrote:
> line length > 80

Done.

https://chromiumcodereview.appspot.com/517353002/diff/1/mojo/python/tests/bin...
File mojo/python/tests/bindings_constants_unittest.py (right):

https://chromiumcodereview.appspot.com/517353002/diff/1/mojo/python/tests/bin...
mojo/python/tests/bindings_constants_unittest.py:22:
self.assertTrue(math.isnan(sample_service_mojom.DOUBLE_NA_N))
On 2014/09/01 12:52:02, pklpkl wrote:
> Shouldn't DOUBLE_NA_N be DOUBLE_NAN instead?

 The issue is that the object is name NaN in the idl file -> there is no wau to
do a correct tranformation with this as an initial value :(

[pkl (ping after 24h if needed), 2014-09-01 14:35:10]

lgtm

https://chromiumcodereview.appspot.com/517353002/diff/1/mojo/public/tools/bin...
File mojo/public/tools/bindings/generators/mojom_python_generator.py (right):

https://chromiumcodereview.appspot.com/517353002/diff/1/mojo/public/tools/bin...
mojo/public/tools/bindings/generators/mojom_python_generator.py:14: def
NameToComponent(name):
On 2014/09/01 14:19:38, qsr wrote:
> On 2014/09/01 12:52:02, pklpkl wrote:
> > style: Function names should be name_to_component().
> 
>  The style of all the python files in mojo/public/tools/bindings/generators
use
> UpperCamelCase for function names.

Ack. Chromium has it's own style guide
http://www.chromium.org/chromium-os/python-style-guidelines for python :(

[qsr, 2014-09-01 15:40:59]

Chris, do you want to take a look?

[Chris Masone, 2014-09-02 17:12:13]

On 2014/09/01 15:40:59, qsr wrote:
> Chris, do you want to take a look?

LGTM, though it'd still be good to get rid of all the not-to-commit files :-)

[qsr, 2014-09-03 07:48:16]

On 2014/09/02 17:12:13, Chris Masone wrote:
> On 2014/09/01 15:40:59, qsr wrote:
> > Chris, do you want to take a look?
> 
> LGTM, though it'd still be good to get rid of all the not-to-commit files :-)

 Why? I'm sure everyone would love to be able to see those directly, don't you
think ?

[qsr, 2014-09-03 07:48:19]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-09-03 07:48:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qsr@chromium.org/517353002/40001

[commit-bot: I haz the power, 2014-09-03 09:33:28]

Committed patchset #3 (id:40001) as 1f6817b1cb3bb585925288303a06f73261dbbb11

[gavinp, 2014-09-03 14:45:00]

On 2014/09/03 09:33:28, I haz the power (commit-bot) wrote:
> Committed patchset #3 (id:40001) as 1f6817b1cb3bb585925288303a06f73261dbbb11

Right now, the null build is about ~299 files. Reverting this CL in my local
repo makes the null build be zero files.

[qsr, 2014-09-03 14:52:27]

Fixed by https://codereview.chromium.org/534263002/

[commit-bot: I haz the power, 2014-09-10 03:24:41]

Patchset 3 (id:??) landed as
https://crrev.com/352a3ed73bb3f015a9db054a3d82820a569b94b6
Cr-Commit-Position: refs/heads/master@{#293105}