Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: runtime/vm/intermediate_language_mips.cc

Issue 517343002: Ensure that BoxInt32 input is correctly preserved on the slow-path. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1811 matching lines...) Expand 10 before | Expand all | Expand 10 after
1822 } 1822 }
1823 return; 1823 return;
1824 } 1824 }
1825 1825
1826 if (IsPotentialUnboxedStore()) { 1826 if (IsPotentialUnboxedStore()) {
1827 Register value_reg = locs()->in(1).reg(); 1827 Register value_reg = locs()->in(1).reg();
1828 Register temp = locs()->temp(0).reg(); 1828 Register temp = locs()->temp(0).reg();
1829 Register temp2 = locs()->temp(1).reg(); 1829 Register temp2 = locs()->temp(1).reg();
1830 DRegister fpu_temp = locs()->temp(2).fpu_reg(); 1830 DRegister fpu_temp = locs()->temp(2).fpu_reg();
1831 1831
1832 if (ShouldEmitStoreBarrier()) {
1833 // Value input is a writable register and should be manually preserved
1834 // across allocation slow-path.
1835 locs()->live_registers()->Add(locs()->in(1), kTagged);
1836 }
1837
1832 Label store_pointer; 1838 Label store_pointer;
1833 Label store_double; 1839 Label store_double;
1834 1840
1835 __ LoadObject(temp, Field::ZoneHandle(field().raw())); 1841 __ LoadObject(temp, Field::ZoneHandle(field().raw()));
1836 1842
1837 __ lw(temp2, FieldAddress(temp, Field::is_nullable_offset())); 1843 __ lw(temp2, FieldAddress(temp, Field::is_nullable_offset()));
1838 __ BranchEqual(temp2, kNullCid, &store_pointer); 1844 __ BranchEqual(temp2, kNullCid, &store_pointer);
1839 1845
1840 __ lbu(temp2, FieldAddress(temp, Field::kind_bits_offset())); 1846 __ lbu(temp2, FieldAddress(temp, Field::kind_bits_offset()));
1841 __ andi(CMPRES1, temp2, Immediate(1 << Field::kUnboxingCandidateBit)); 1847 __ andi(CMPRES1, temp2, Immediate(1 << Field::kUnboxingCandidateBit));
(...skipping 2968 matching lines...) Expand 10 before | Expand all | Expand 10 after
4810 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs()); 4816 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs());
4811 #if defined(DEBUG) 4817 #if defined(DEBUG)
4812 __ LoadImmediate(S4, kInvalidObjectPointer); 4818 __ LoadImmediate(S4, kInvalidObjectPointer);
4813 __ LoadImmediate(S5, kInvalidObjectPointer); 4819 __ LoadImmediate(S5, kInvalidObjectPointer);
4814 #endif 4820 #endif
4815 } 4821 }
4816 4822
4817 } // namespace dart 4823 } // namespace dart
4818 4824
4819 #endif // defined TARGET_ARCH_MIPS 4825 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698