Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 517313002: Create build/linux/unbundle file for protobuf (Closed)

Created:
6 years, 3 months ago by Paweł Hajdan Jr.
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Create build/linux/unbundle file for protobuf BUG=none Committed: https://crrev.com/1f15f3a9e425389a828ada84860a62d9d1e25e9b Cr-Commit-Position: refs/heads/master@{#292773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -0 lines) Patch
A build/linux/unbundle/protobuf.gyp View 1 chunk +149 lines, -0 lines 0 comments Download
M build/linux/unbundle/replace_gyp_files.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Paweł Hajdan Jr.
phajdan.jr@chromium.org changed reviewers: + thestig@chromium.org
6 years, 3 months ago (2014-08-29 12:39:14 UTC) #1
Paweł Hajdan Jr.
6 years, 3 months ago (2014-08-29 12:39:14 UTC) #2
Lei Zhang
lgtm
6 years, 3 months ago (2014-08-29 15:32:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/517313002/1
6 years, 3 months ago (2014-08-30 03:14:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 712e4e14f98bbfcb16fa3fe9c71600c6bf485ef3
6 years, 3 months ago (2014-08-30 05:22:54 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:13:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f15f3a9e425389a828ada84860a62d9d1e25e9b
Cr-Commit-Position: refs/heads/master@{#292773}

Powered by Google App Engine
This is Rietveld 408576698