Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2023)

Issue 517293002: Convert some Internals APIs to use DOMPoint instead of WebKitPoint (Closed)

Created:
6 years, 3 months ago by philipj_slow
Modified:
6 years, 3 months ago
Reviewers:
zino, Rick Byers
CC:
blink-reviews, arv+blink, Inactive
Project:
blink
Visibility:
Public.

Description

Convert some Internals APIs to use DOMPoint instead of WebKitPoint This is the only internal usage of WebKitPoint. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M Source/core/testing/Internals.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/testing/Internals.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
philipj@opera.com changed reviewers: + jinho.bang@samsung.com, rbyers@chromium.org
6 years, 3 months ago (2014-08-29 12:15:50 UTC) #1
philipj_slow
PTAL. This is to make the eventual WebKitPoint removal smaller.
6 years, 3 months ago (2014-08-29 12:15:50 UTC) #2
zino
On 2014/08/29 12:15:50, philipj wrote: > PTAL. This is to make the eventual WebKitPoint removal ...
6 years, 3 months ago (2014-08-29 12:34:39 UTC) #3
Rick Byers
lgtm
6 years, 3 months ago (2014-08-29 13:48:57 UTC) #4
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 3 months ago (2014-08-29 14:16:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/517293002/1
6 years, 3 months ago (2014-08-29 14:17:20 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-08-29 14:21:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181095

Powered by Google App Engine
This is Rietveld 408576698